Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generality of PTO module; non-hydro DOFs #246

Open
cmichelenstrofer opened this issue Jun 26, 2023 · 1 comment
Open

Improve generality of PTO module; non-hydro DOFs #246

cmichelenstrofer opened this issue Jun 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cmichelenstrofer
Copy link
Member

For more complex WECs the PTO kinematics might depend not only on the hydrodynamic DOFs but also on additional DOFs. The PTO module is not set up to handle this.

Initially we though of the PTO module as an 'example' but after some discussions we want to make it more general. Else it would be a lot of copy-paste.

Proposed solution:

  • core only deals with the full x vector.
  • we provide a decompose function that splits it into 4 different variables: hydrodynamic DOFs, non-hydro DOFs, PTO Force, others.
  • The PTO module's kinematic matrix will depend on both the hydro and non-hydro dofs.
@cmichelenstrofer cmichelenstrofer added the enhancement New feature or request label Jun 26, 2023
@cmichelenstrofer cmichelenstrofer self-assigned this Jun 26, 2023
@ryancoe
Copy link
Collaborator

ryancoe commented Jul 13, 2023

Note that if/when we make changes to the decision variable x to resolve this issue, we will need to make updates to implementation.rst and theory.rst.

Also, here's the diagram that Giorgio and I developed years ago when we were figuring out how to structure WecOptTool.

WecOptTool_integratedStructure

@cmichelenstrofer cmichelenstrofer changed the title Improve generality of PTO module Improve generality of PTO module; non-hydro DOFs Oct 10, 2023
@cmichelenstrofer cmichelenstrofer added this to the v3.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants