Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword Position Reports: Hide search engine columns that have no results #118

Open
jas8522 opened this issue Jan 27, 2019 · 0 comments
Open

Comments

@jas8522
Copy link

jas8522 commented Jan 27, 2019

Customers can use different search engines for various websites and keywords. Often a particular search engine locale is of no application to an entire site's keywords. When there's no keyword reports for any given search engine (because the search engine isn't active for those keywords), those columns should be hidden from display.

There are dozens more keywords than I've captured in this screenshot, and the Australia search engines are not in use for any of them, making the columns useless for this particular website.
empty-search-engines

The simple way to fix this would be to detect if the column data is empty for all keywords when generating the report and simply not display those columns.

The more in-depth solution would be to allow assigning search engines to websites. When adding/editing a keyword, you would only be able to select from the search engines assigned to the site. This way, rather than having to check if data exists in the column before displaying it (or not), the code could simply look up whether the search engine is assigned to the website and never actually even query the database for any search engines that are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant