Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply corrections to family store and clif #217

Closed
14 tasks done
plastikfan opened this issue Oct 21, 2023 · 1 comment · Fixed by #218
Closed
14 tasks done

apply corrections to family store and clif #217

plastikfan opened this issue Oct 21, 2023 · 1 comment · Fixed by #218
Assignees
@plastikfan
Labels
bug Something isn't working

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Oct 21, 2023 •
edited
Loading

  • Expand doesn't have a forwarding alias
  • (there is another scenario where ThirdPartyCommandLine is being abused, but I can't remember it!)
  • make sure ExternalThirdParty has correct members (add ExecutionFlags ThirdPartyCommandLine)
  • add a Positional type = []string
  • check the FlagSet (don't assume the family parameter sets will be defined on the root command)
  • define file-only filter family
  • define folder-only filter family
  • define a PolyFilter family that has consisting of compound Files And Folders
  • rename self to parent
  • re-evaluate the short flag names for the filters
  • rename Present to Specified
  • ExternalThirdParty.KnownBy should be of type KnownByCollection
  • dry-run family test named incorrectly ("profile family" => "preview family")
  • BindAll needs an optional FlagSet parameter. If a FlagSet is provided then the flag set should be created using NewFlagInfoOnFlagSet otherwise use the default NewFlagInfo eg (with alt):
 paramSet.BindString(
    assistant.NewFlagInfoOnFlagSet("pattern", "p", "default-pattern",
      widgetCommand.PersistentFlags()), &paramSet.Native.Pattern,
  )
@plastikfan plastikfan added the bug Something isn't working label Oct 21, 2023
@plastikfan plastikfan self-assigned this Oct 21, 2023
@plastikfan plastikfan changed the title apply corrections to clif functions apply corrections to family store Oct 24, 2023
@plastikfan plastikfan changed the title apply corrections to family store apply corrections to family store and clif Oct 24, 2023
@plastikfan
Copy link
Contributor Author

actually ExternalThirdParty may not have to contain ExecutionFlags as previously suggested as it already contains a Known member of the same type. But Known is a bit ambiguous so let's rename it ExecutionFlags.

plastikfan added a commit that referenced this issue Oct 24, 2023
@plastikfan
fix(store): apply corrections to aid ease of use (#217)
14e7073 
fix(clif): correct postional types (#217)

fix(clif): rename present to specified (#217)

fix(clif): rename self to parent (#217)

fix(store): rename FilterParameterSet to PolyFilterParameterSet (#217)

fix(store): add optional additional flagset parameter to BindAll (#217)

fix(store): redefine filter families (#217)

fix(store): redefine short filter flag names (#217)
@plastikfan plastikfan mentioned this issue Oct 24, 2023
Merged
plastikfan added a commit that referenced this issue Oct 24, 2023
@plastikfan
fix(store): apply corrections to aid ease of use (#217)
6448fc9 
fix(clif): correct postional types (#217)

fix(clif): rename present to specified (#217)

fix(clif): rename self to parent (#217)

fix(store): rename FilterParameterSet to PolyFilterParameterSet (#217)

fix(store): add optional additional flagset parameter to BindAll (#217)

fix(store): redefine filter families (#217)

fix(store): redefine short filter flag names (#217)
@plastikfan plastikfan linked a pull request Oct 24, 2023 that will close this issue
fix(store): apply corrections to aid ease of use (#217) #218
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(store): apply corrections to aid ease of use (#217) snivilised/cobrass
1 participant
@plastikfan