Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F-REQ] Add withCount same way as $itemWith and $collectionWith #14

Open
leon0399 opened this issue Aug 30, 2019 · 2 comments
Open

[F-REQ] Add withCount same way as $itemWith and $collectionWith #14

leon0399 opened this issue Aug 30, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@leon0399
Copy link

Is your feature request related to a problem? Please describe.
It's now unable to add counts for relations in API without overriding almost all functions in default Controller at laravel5-api-boilerplate, so it'll be nice to add such functions to this library

Describe the solution you'd like
Add a new variable and function to RestfulModel the same way, as $itemWith and $collectionWith: $itemWithCount and $collectionWithCount

Describe alternatives you've considered
IMHO, there is no other alternatives

Additional context
@specialtactics let me know, if you like this feature, and I'll start working on PR

@specialtactics
Copy link
Owner

Hi @leon0399 - thanks for your interest.

I've never used that before, but after doing some research, I think it makes sense to add it. If you would like to do a PR to add it, then that's even better 😄

@specialtactics specialtactics self-assigned this Sep 2, 2019
@specialtactics specialtactics added the enhancement New feature or request label Sep 2, 2019
@leon0399
Copy link
Author

Sorry, I'm still working on main project with your template 🤣

I'll contribute asap, when finish the project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants