Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cancelled status for course sections #109

Open
galacticglum opened this issue Jul 19, 2022 · 4 comments
Open

Show cancelled status for course sections #109

galacticglum opened this issue Jul 19, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@galacticglum
Copy link
Member

galacticglum commented Jul 19, 2022

If a section has been cancelled (cancelled attribute on the Section returned by gator), we should show the section as cancelled on the client and make it disabled (can't add it to timetable).

We might also want to notify users who have added the cancelled section to their timetable.

@galacticglum galacticglum added the good first issue Good for newcomers label Jul 19, 2022
@eamonma
Copy link
Member

eamonma commented Jul 21, 2022

Notifications would necessitate a more elaborate discussion, regarding the scope, implementation, and service provider. I think we can hold off on that part for now.

@galacticglum
Copy link
Member Author

Agreed. I mostly just wanted to have a "paper trail" for that idea so we don't forget it. Someone (or I can) should open a ticket for it though.

@eamonma
Copy link
Member

eamonma commented Jul 21, 2022

We can expand the scope of #80 to adding notifications in general.

@eamonma
Copy link
Member

eamonma commented Aug 1, 2022

To flesh this one out more, if someone has already added it to the timetable, it should be shown as cancelled in the overview, in the style similar to a no credit course such as PDC, and not counted as credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants