Not updating project.pbxproj?

[GrabbenD]

The CURRENT_PROJECT_VERSION entries in ios/{project_name}.xcodeproj/project.pbxproj aren't being updated when the package is executed. Is there anything that we can do about that?

[GrabbenD]

Found the issue. It's due to target.name === appPkg.name condition. The solution is to update "name": in the main package.json to match the prefix of the project folder in ios/ directory. E.g "name": "MyProject" if
you've got ios/MyProject.xcodeproj. It's not ideal since in our case it's not following the lowercase convention but it's okay.

react-native-version/index.js

Line 402 in f5577a2

if (target.name === appPkg.name) {

[stovmascript]

I guess we could change this condition to always test both properties after converting them .toLowerCase(). Do you want to make a PR?

[geraintwhite]

This check also means it won't work for multiple targets. It updates both Info.plist files but only one of the targets in the project.pbxproj.

[geraintwhite]

Using --legacy and setting CURRENT_PROJECT_VERSION in the project rather than the targets seems to do the trick.

[dmlitvinov]

Using --legacy and setting CURRENT_PROJECT_VERSION in the project rather than the targets seems to do the trick.

Incredible, but it works as it should!
Thank you