Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to specify the exact format of DID URL we expect #158

Closed
TallTed opened this issue Sep 20, 2023 · 5 comments
Closed

We need to specify the exact format of DID URL we expect #158

TallTed opened this issue Sep 20, 2023 · 5 comments
Assignees

Comments

@TallTed
Copy link
Member

TallTed commented Sep 20, 2023

Originally posted by @msporny in #153 (comment)

We need to specify the exact format that we expect here... DID URL -- but is this a relative (fragment-only thing) or a fully qualified DID URL (DID URL + fragment). What issue is dealing w/ this?


I opened this fresh issue because it's a better home for this discussion than a comment on a pull request.

@OR13
Copy link
Contributor

OR13 commented Sep 22, 2023

I agree this issue blocks CR.

I recommend we say the following:

kid MUST be an absolute URL.
kid MUST start with the issuer identifier used in the verifiable credential, or the holder identifier in a verifiable presentation.

I don't believe DIDs should be mentioned at all, since they are not mentioned in https://w3c.github.io/vc-data-integrity/#verification-methods

The value of the id property for a verification method MUST be a string that conforms to the conforms to the [URL] syntax.

@msporny
Copy link
Member

msporny commented Sep 23, 2023

Agree with @OR13's suggested normative language above.

@selfissued
Copy link
Collaborator

I disagree with the assertion that kid must be an absolute URL. I'm fine with it being an absolute URL when the key is being retrieved from a DID (or more generally, a controller document). But when retrieving keys from JWK Sets, the kid needs to be able to be any string, since the JWK Set authors get to choose their kid values.

@OR13
Copy link
Contributor

OR13 commented Sep 26, 2023

@selfissued can you revise your suggestion and address the example in the spec: https://w3c.github.io/vc-data-model/#example-a-simple-example-of-a-verifiable-credential

@OR13 OR13 self-assigned this Sep 29, 2023
@OR13
Copy link
Contributor

OR13 commented Oct 13, 2023

I think has been handled by:

@OR13 OR13 closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants