You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There may be cases where a large arabic number needs to be converted to a roman number. Should we implement that? I have read about Vinculum system as it seems to be the most widely used.
It should be viable to implement it for handling numbers between the [4000,3999999] range. I have done a quick (and ugly 😄) patch in order to filter the generated number (note that I have only implemented the arabic to roman conversion):
if (4000 <= $this->arabicNumeral && 3999999 >= $this->arabicNumeral) {
return sprintf(
'<span class="overline">%s</span>%s',
str_replace('N', '', (new IntToRoman())->filter(intval(substr($this->arabicNumeral, 0, -3)))),
str_replace('N', '', (new IntToRoman())->filter(intval(substr($this->arabicNumeral, -3))))
);
} else {
return (new IntToRoman())->filter($this->arabicNumeral);
}
The text was updated successfully, but these errors were encountered:
There may be cases where a large arabic number needs to be converted to a roman number. Should we implement that? I have read about Vinculum system as it seems to be the most widely used.
It should be viable to implement it for handling numbers between the [4000,3999999] range. I have done a quick (and ugly 😄) patch in order to filter the generated number (note that I have only implemented the arabic to roman conversion):
The text was updated successfully, but these errors were encountered: