You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when you run composer update and api.w.org isn't available you get two misleading warnings. Example:
> Required\ComposerScripts\PluginAvailability::checkAvailability
The plugin wpackagist-plugin/facebook-conversion-pixel does not seem to be available in the WordPress Plugin Directory anymore
> Required\ComposerScripts\PluginAvailability::checkMaintenanceStatus
The plugin wpackagist-plugin/facebook-conversion-pixel has not been updated in over two years. Please double-check before using it.
- Updating wpackagist-plugin/facebook-conversion-pixel (2.0.1 => 2.1.0): Downloading (100%)
I suggest to check the HTTP response and provide some more information in this case. Or skip any checks.
The text was updated successfully, but these errors were encountered:
isPluginAvailable() and isPluginActivelyMaintained() are already trying to catch an ErrorException exception. So if loadPluginData() would return an exception in case of an unavailable API we could instead return true in both methods and print a debug message (once?) that the API couldn't be reached.
We could probably add a private property to the class and set that flag once the API is not available. At the end, add an info/warning if the flag is set.
What if the API is only unavailable for some requests?
Also, it's probably easier to add a custom Exception class for this.
Currently when you run
composer update
and api.w.org isn't available you get two misleading warnings. Example:I suggest to check the HTTP response and provide some more information in this case. Or skip any checks.
The text was updated successfully, but these errors were encountered: