Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the space error seen with OON on GitHub! #40

Open
xparq opened this issue Oct 10, 2023 · 0 comments
Open

Investigate the space error seen with OON on GitHub! #40

xparq opened this issue Oct 10, 2023 · 0 comments

Comments

@xparq
Copy link
Owner

xparq commented Oct 10, 2023

If the NMAKE path in $(MAKE) contains spaces, this command failed, _until I removed the quotes from the supposedly unrelated DIR= clause!... :-o

rem ... !_make_! ... "DIR=!_dir_!" would FAIL if the NMAKE path has spaces! :-ooo
if exist %%i\*.%%x !_make_! /c compiling DIR=!_dir_! SRC_EXT_=%%x $(custom_build_options) || if errorlevel 1 exit -1

-> xparq/Out_of_Nothing#194, #5!

-> Also, I've seen it locally on a fresh Win10 test OON setup: the problem there was double-quoting $(MAKE)! (Fixed only there yet!) It seems NMAKE does it already for paths like "C:\Program Files"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant