Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview deployments on PRs #301

Open
Zoobdude opened this issue Nov 22, 2024 · 5 comments
Open

Preview deployments on PRs #301

Zoobdude opened this issue Nov 22, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Zoobdude
Copy link
Contributor

Zoobdude commented Nov 22, 2024 •
edited
Loading

A GitHub action to build and deploy a preview of the site on PRs to help with easy review.

I think this was attempted to be setup a while back with Vercel, but never fully implemented.

Maybe it would be easier if it used GitHub pages instead?

I would happily write and/or setup the GH action, if one of the maintainers would be prepared to populate the keys and finish the setup.
@NOCanoa
Copy link
Member

NOCanoa commented Nov 23, 2024

yeah sure!,
but only the prs, main site will stay on cf, to mutch trafic for gh pages xP

@NOCanoa
Copy link
Member

NOCanoa commented Nov 25, 2024

btw we moving to Astrojs

@Zoobdude
Copy link
Contributor Author

I'll build this for astro then and put it straight into the other branch if that works for you?

@NOCanoa
Copy link
Member

NOCanoa commented Nov 25, 2024

yeah just do a pr and let me know, btw u in discord?

@Zoobdude
Copy link
Contributor Author

Yep, its ZoobDude

@NOCanoa NOCanoa added the enhancement New feature or request label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zoobdude @NOCanoa