Merge pull request #14 from 2hire/split-slack-attachments

fix: changed import to the actual json framework
2hire · Oct 10, 2023 · 13ad292 · 13ad292
2 parents 0baac59 + fb62834
commit 13ad292
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,5 +1,5 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-yarn precommit
-./hooks/pre-commit.nocommit
+# yarn precommit
+# ./hooks/pre-commit.nocommit
diff --git a/src/metabase/pulse.clj b/src/metabase/pulse.clj
@@ -1,6 +1,7 @@
 (ns metabase.pulse
   "Public API for sending Pulses."
   (:require
+   [cheshire.core :as json]
    [clojure.string :as str]
    [metabase.api.common :as api]
    [metabase.config :as config]
@@ -531,11 +532,13 @@
   [{:keys [channel-id message attachments]}]
   (let [attachments (create-and-upload-slack-attachments! attachments)]
     (try
-      (log/error "TestNonLoop" (trs "Sending Slack message with {0} attachments" (count attachments)))
+      (log/error "TestNonLoop" (trs "Sending Slack message with {0} attachments: {1}" (count attachments) (json/generate-string attachments)))
       (slack/post-chat-message! channel-id message attachments)
       (catch ExceptionInfo e
         ;; Token errors have already been logged and we should not retry.
         (when-not (contains? (:errors (ex-data e)) :slack-token)
+          ;; Logging errors here for debug
+          (log/error e (trs "Error sending Slack message with {0} attachments" (count attachments)))
           (throw e))))))
 
 (defmethod send-notification! :email