[CI] Add embroider-safe scenario #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11y-testing) is not embroider compatible
bantic
force-pushed
the
bantic/add-embroider
branch
from
4897d17 to
4a5700c
Compare
bantic
changed the title
bantic
commented
Jan 8, 2025
| @@ -41,9 +41,12 @@ jobs: | |||
| timeout-minutes: 10 | |||
|
|
|||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Semi unrelated. This allows all ember-try scenarios to run to completion.
bantic
commented
Jan 8, 2025
| @@ -100,6 +103,7 @@ | |||
| }, | |||
| "homepage": "https://Addepar.github.io/ember-table", | |||
| "resolutions": { | |||
| "@ember/test-waiters": "^3.0.2", | |||
There was a problem hiding this comment.
ember/test-waiters at 3.0.1 is not compatible with embroider. We fix this using a resolution because it's a secondary dependency of ember-a11y-testing, and bumping ember-a11y-testing to the ^5.2.1 range did not pick up the newer ember/test-waiters.
In a follow-up I'll attempt to upgrade ember-a11y-testing, at which point we can probably remove this.
bantic
commented
Jan 8, 2025
| "@ember/test-helpers": "^2.8.1", | ||
| "@embroider/test-setup": "^4.0.0", | ||
| "@glimmer/component": "^1.1.2", |
There was a problem hiding this comment.
embroider complains if this isn't present because the dummy app imports from it here:
mixonic
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the guidance at https://github.com/embroider-build/embroider/tree/main/packages/test-setup and adds
embroider-safeandembroider-optimizedscenarios to the ember-try config.This PR only enables the embroider-safe scenario because the embroider-optimized one has some failures, largely due to the fact that
ember-cli-addon-docsis not installed by default (it is only installed for the ember-try scenario namedember-default-docs) but it is referenced from the dummy app in multiple places. The embroider-safe CI run succeeds, but the embroider-optimized (rightly, imo) complains about it.The embroider-optimized scenario also fails because some of the tests use dynamic components (here, in specific:
ember-table/tests/helpers/generate-table.js
Line 64 in 04a4e5e