Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: avoid effect overspeed during transitions (solves #4446) #4477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

softhack007
Copy link
Collaborator

this still raises FPS during transitions, but only for effects that normally run very slow (solid).

this still raises FPS, but only for effects that normally run very slow (solid).
@softhack007 softhack007 requested a review from blazoncek January 10, 2025 12:36
@blazoncek
Copy link
Collaborator

Not a correct solution.
Effect functions need to be modified, there is no way around it.

@DedeHai
Copy link
Collaborator

DedeHai commented Jan 10, 2025

I still don't know why these FX do not run at full speed... I could fix them but have other priorities ATM.
if you want a fixed frame rate without fixed frame-time: I have one possible implementation done in PS 2D Fire FX that also solves transition flickering: the FX renders the frame but does not update any parameters so the frame is identical to the last. maybe some of these FX could do the same or something similar?
I agree that this PR is more of a patch-up than a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants