Only emit shard events on change #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Haider-Ali-DS
commented
Dec 23, 2024
•
Haider-Ali-DS
commented
- Only emit events if setShard or revokeShard do any changes in storage
- Add unit_test for changes.
add test for shard events
Haider-Ali-DS
force-pushed
the
only-emit-shard-events-on-change
branch
from
3f26445 to
fa203a3
Compare
Lohann
reviewed
Dec 23, 2024
Lohann
approved these changes
Dec 23, 2024
| @@ -243,6 +243,79 @@ contract GatewayBase is Test { | |||
| } | |||
| } | |||
|
|
|||
| function test_shardEvents() external { | |||
There was a problem hiding this comment.
Neat, thanks for writting this test !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.