Make sensei_start_course_form() text filterable #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pull request, so I tried to make it simple – please let me know if I can improve anything! |
donnapep
reviewed
Mar 2, 2021
| @@ -99,11 +99,13 @@ function sensei_start_course_form( $course_id ) { | |||
| if ( $prerequisite_complete ) { | |||
| wp_enqueue_script( 'sensei-stop-double-submission' ); | |||
|
|
|||
| $sensei_start_course_form_text = apply_filters( 'sensei_start_course_form_text', esc_html( 'Take This Course', 'sensei-lms' ) ); | |||
There was a problem hiding this comment.
I think we should consider calling this filter something else to more accurately describe what it filters. What about sensei_take_course_button_text?
|
@anekola Thanks for the PR. There's a PHP linting error that will need to be addressed before this PR can be merged. Also, I wanted to let you know that when you create a new course now, it will use blocks. There is actually a Take Course block that enables customizing the button text right in the editor. Thought I'd mention it in case you'd like to give blocks a try instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4019
Changes proposed in this Pull Request
Testing instructions
New/Updated Hooks