Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix students context menu" #6459

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Feb 2, 2023

Reverts #6440

It looks like #6440 introduced failing checks (also reproducible locally).

For some reason, it also affects our release PR (#6436) (reproducible only in CI!) even though it doesn't contain those changes.

As we can see here, reverting "fixes" JS and coverage checks.

I'd like to revert those changes and return the original issue in work.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6459 (cbdaff9) into trunk (f4d9f37) will increase coverage by 0.06%.
The diff coverage is 29.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #6459      +/-   ##
============================================
+ Coverage     46.74%   46.81%   +0.06%     
  Complexity     9737     9737              
============================================
  Files           464      464              
  Lines         34370    34378       +8     
  Branches        275      276       +1     
============================================
+ Hits          16067    16093      +26     
+ Misses        18098    18079      -19     
- Partials        205      206       +1     
Impacted Files Coverage Δ
assets/admin/editor-wizard/patterns-list.js 26.66% <0.00%> (ø)
assets/admin/editor-wizard/steps/patterns-step.js 21.73% <0.00%> (-6.04%) ⬇️
...ludes/blocks/course-theme/class-course-content.php 9.09% <0.00%> (+0.20%) ⬆️
includes/class-sensei-lesson.php 36.99% <0.00%> (-0.04%) ⬇️
...ncludes/blocks/class-sensei-block-view-results.php 92.85% <100.00%> (+0.26%) ⬆️
...udes/blocks/class-sensei-continue-course-block.php 93.02% <100.00%> (+0.16%) ⬆️
...udes/blocks/class-sensei-course-progress-block.php 91.66% <100.00%> (+29.16%) ⬆️
includes/blocks/shared/class-progress-bar.php 85.00% <0.00%> (+85.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1897067...cbdaff9. Read the comment docs.

@merkushin merkushin marked this pull request as ready for review February 2, 2023 09:08
@merkushin merkushin requested review from mikeyarce and a team February 2, 2023 09:08
@merkushin merkushin changed the title Revert " Fix students context menu" Revert "Fix students context menu" Feb 2, 2023
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap, that fixed the errors for me locally 👍

@merkushin merkushin merged commit bb122ad into trunk Feb 2, 2023
@merkushin merkushin deleted the revert-6440-fix/students-modal-menu branch February 2, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants