-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of deprecated parameters in WordPress Core functions #7724
Open
donnapep
wants to merge
8
commits into
trunk
Choose a base branch
from
fix/wordpress-core-deprecations
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't find any calls to it in Sensei or any extensions. This is the commit where it was originally added and wasn't being called anywhere at that time either - 18676be.
donnapep
force-pushed
the
fix/wordpress-core-deprecations
branch
from
January 10, 2025 17:04
9b19080
to
9b90058
Compare
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for https://github.com/Automattic/sensei-security/issues/19.
Proposed Changes
get_term_authors
function as I was unable to find any calls to it either in Sensei or any of its extensions. It was first added here, which didn't call the function either. 😕wp_count_terms
function to pass a single parameter.get_terms
function to pass a single parameter.There is one more deprecation fix needed in the
class-sensei-learners-main.php
file. The problem line is part of what appears to be obsolete code, so I'm planning to remove it in a separate PR.Testing Instructions
trunk
, enable usage tracking.sensei_usage_tracking_send_usage_data
job.sensei_stats_log
event in Tracks and note the value ofmodules_max
andmodules_min
.sensei_usage_tracking_send_usage_data
job and ensure the values noted in step 3 are the same.[sensei_course_categories exclude="123,xxx"]
shortcode to a page, where123
is a course category ID andxxx
is a course category slug to exclude.Deprecated Code
Sensei_Core_Modules::get_term_authors
Pre-Merge Checklist