CGPROD-1585 Accessible DOM element (#287)

* Calls to 'visible' on accessible dom elements now reliable after creation. * Update test
BBC-archive · Aug 5, 2019 · f180c2b · f180c2b
1 parent 546676e
commit f180c2b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 | Version | Description |
 |---------|-------------|
+| 2.0.5 | |
+| | Calls to 'visible' on accessible dom elements now reliable after creation. (CGPROD-1585) |
 | 2.0.4 | |
 | | Button accessibility hot fix. (CGPROD-1577) |
 | 2.0.3 | |

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "genie",
-    "version": "2.0.4",
+    "version": "2.0.5",
     "description": "Genie - A Modular Game Engine",
     "license": "Apache-2.0",
     "private": true,

diff --git a/src/core/accessibility/accessible-dom-element.js b/src/core/accessibility/accessible-dom-element.js
@@ -66,7 +66,7 @@ export function accessibleDomElement(options) {
     }
 
     function visible() {
-        return el.style.visibility === "visible";
+        return el.style.visibility !== "hidden";
     }
 
     function position(positionOptions) {

diff --git a/test/core/accessibility/accessible-dom-element.test.js b/test/core/accessibility/accessible-dom-element.test.js
@@ -213,6 +213,11 @@ describe("Accessible DOM Element", () => {
     });
 
     describe("checking visibility of mockElement", () => {
+        test("calling visible function returns true when mockElement has been created", () => {
+            const newAccessibleElement = accessibleDomElement(options);
+            expect(newAccessibleElement.visible()).toBe(true);
+        });
+
         test("calling visible function returns true when mockElement is visible", () => {
             const newAccessibleElement = accessibleDomElement(options);
             newAccessibleElement.show();