Replace gnome build artifacts with budgie equivalents #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BuddiesOfBudgie/best-buds Think this is ready at least to build and install on your favourite distro For ubuntu I have a PPA for this https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/budgie-session Just need to remove post install gnome-session-bin and gnome-session-common (on ubuntu) - i.e. the equivalent gnome-session package for your distro. EDIT: remember to change "gnome-session" for "budgie-session" in /usr/bin/budgie-desktop |
|
Trying to use this in a VM on Solus, and it immediately brings me back to the login greeter when trying to log in. I don't see anything in the journal log. I did change Copied the package.yml from our name : budgie-session
version : '0.9'
release : 1
source :
- git|https://github.com/BuddiesOfBudgie/budgie-session.git : fcad448c119532aa054c539fdd171103e0114cf4
homepage : https://buddiesofbudgie.org
license : GPL-2.0-or-later
summary :
- Provides Budgie session core
description:
- Provides Budgie session core
component :
- desktop.budgie
builddeps :
- pkgconfig(gl)
- pkgconfig(gnome-desktop-3.0)
- pkgconfig(json-glib-1.0)
- pkgconfig(sm)
- pkgconfig(upower-glib)
- pkgconfig(xtrans)
- pkgconfig(xtst)
- docbook-xml
- xmlto
rundeps :
- gsettings-desktop-schemas
- gvfs
- udisks
- upower
- xdg-desktop-portal-gtk
- xdg-user-dirs
- xdg-user-dirs-gtk
- xdg-utils
setup : |
%patch -p1 -i $pkgfiles/0001-Fix-grep-error-for-etc-shells-on-Solus.patch
%patch -p1 -i $pkgfiles/0001-Replace-gnome-build-artifacts-with-budgie.patch
%meson_configure -Dsystemd=true \
-Dsystemd_journal=true
build : |
%ninja_build
install : |
%ninja_installResults in a package with these files: <Files>
<Path fileType="executable">/usr/bin/budgie-session</Path>
<Path fileType="executable">/usr/bin/budgie-session-inhibit</Path>
<Path fileType="executable">/usr/bin/budgie-session-quit</Path>
<Path fileType="library">/usr/lib64/budgie-session/budgie-session-binary</Path>
<Path fileType="library">/usr/lib64/budgie-session/budgie-session-check-accelerated</Path>
<Path fileType="library">/usr/lib64/budgie-session/budgie-session-check-accelerated-gl-helper</Path>
<Path fileType="library">/usr/lib64/budgie-session/budgie-session-check-accelerated-gles-helper</Path>
<Path fileType="library">/usr/lib64/budgie-session/budgie-session-failed</Path>
<Path fileType="data">/usr/share/budgie-session/hardware-compatibility</Path>
<Path fileType="data">/usr/share/glib-2.0/schemas/org.buddiesofbudgie.SessionManager.gschema.xml</Path>
<!-- Omitted the localization files -->
<Path fileType="man">/usr/share/man/man1/budgie-session-inhibit.1</Path>
<Path fileType="man">/usr/share/man/man1/budgie-session-quit.1</Path>
<Path fileType="man">/usr/share/man/man1/budgie-session.1</Path>
</Files> |
|
For UB this is the file sizes and contents of the built budgie-session - can you please see if it compare somewhat with yours? |
|
your libraries are stored in /usr/lib64 whereas in ubuntu they are stored in libexec. Significant? Also are they the same executable permission bits for those additional (libexec) executables as per UB? |
|
Files: |
|
@EbonJaeger your /usr/bin/budgie-session isn't executable? |
|
Where in the tree is that built? I'm having trouble finding it. |
|
budgie-session/gnome-session/meson.build Line 10 in 6d9da5d |
|
I wonder if it's because the budgie-session package is using the git repo whereas the gnome-session package is using a release tarball. Not seeing any other difference. It seems to be working after adding |
|
Possibly - I guessing just taking the patch from git isn't taking the budgie-session.in executable bit. Anyway - thanks for the confirmation - nice to hear that preliminary it works on Solus. |
|
Reporting in that this PR worked with no issues on my end. I'm not quite sure why it wasn't working for @EbonJaeger, but in my case Aside from doing some "rpm-ostree"-specific changes and work to facilitate development on Onyx and the required change in budgie-desktop, I don't think I've done anything particularly special:
ls output showing budgie-session executables with executable bit set ps output showing I am actually using budgie-session |
JoshStrobl
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line of the aim for a "softish" fork - this PR replaces gnome-session build artifacts with budgie equivalents to ensure budgie-session and gnome-session can be co-installed without interfering with each other from a packaging POV.
The build mechanism no longer installs the systemD targets nor the default gnome sessions.
Note - separate PR required to change /usr/bin/budgie-desktop to execute budgie-session rather than gnome-session
Next steps before marking as ready:
"the session manager is the bit that interacts between the login manager (lightdm) and budgie-desktop (magpie). it tells the window manager whether to use accelerated graphics. It allows budgie to suspend/shutdown/logout. it also provides the autostart apps capability."