Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dTiles dependency #173

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Remove dTiles dependency #173

merged 1 commit into from
Feb 10, 2022

Conversation

dvvanessastoiber
Copy link
Contributor

Closes #172

@thinkh thinkh changed the title Remove dTiles Remove dTiles dependency Feb 10, 2022
thinkh
thinkh reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@thinkh
Copy link
Member

thinkh commented Feb 10, 2022

An additional note: The dTilesSearchProvider is still registered as extension point in the phovea.ts. We decided to leave the type as string here and do not import the EP constant from dTiles. Otherwise we wouldn't be able to remove the dependency.

As Vanessa mentioned before, there is currently no Tiles instance with tdp_publicdb.

@thinkh thinkh merged commit 63ba74a into develop Feb 10, 2022
@thinkh thinkh deleted the vstoiber/127_remove_dtiles branch February 10, 2022 20:36
@keckelt keckelt mentioned this pull request Apr 5, 2022
Open
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 27, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@puehringer puehringer Awaiting requested review from puehringer

Assignees

@thinkh thinkh

@puehringer puehringer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvvanessastoiber @thinkh @puehringer