Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Explicitly define copy constructor for AnyBase #1834

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

g3bk47
Copy link
Contributor

@g3bk47 g3bk47 commented Dec 29, 2024

Changes proposed in this pull request

Gcc 14.2 generates a warning (-Wdeprecated-copy) for AnyBase because the assignment operator is defined explicitly but the copy constructor is defined implicitly.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Gcc 14.2 generates a warning (-Wdeprecated-copy) for AnyBase because the assignment operator is defined explicitly but the copy constructor is defined implicitly.
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g3bk47 … this change looks good to me.

@ischoegl ischoegl merged commit 2e0d8ac into Cantera:main Dec 31, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants