chore: update lighthouse to latest unstable version in sim tests #7364
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7364 +/- ##
=========================================
Coverage 48.62% 48.62%
=========================================
Files 603 603
Lines 40507 40507
Branches 2071 2071
=========================================
Hits 19697 19697
Misses 20772 20772
Partials 38 38 |
nflaig
changed the title
nflaig
commented
Jan 15, 2025
| @@ -4,7 +4,7 @@ | |||
| GETH_DOCKER_IMAGE=ethereum/client-go:v1.13.14 | |||
| # Use either image or local binary for the testing | |||
| GETH_BINARY_DIR= | |||
| LIGHTHOUSE_DOCKER_IMAGE=sigp/lighthouse:v5.1.1-amd64-modern-dev | |||
| LIGHTHOUSE_DOCKER_IMAGE=sigp/lighthouse:latest-amd64-unstable | |||
There was a problem hiding this comment.
-dev is no longer needed (does not exist anymore), all images come with minimal preset now
wemeetagain
approved these changes
Jan 15, 2025
nazarhussain
approved these changes
Jan 15, 2025
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7339 and #6821