test(rsbuild-plugin-angular): test component resolver and devkit for ng versions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/rsbuild-plugin-angular/src/lib/plugin/utils/utils.ts # packages/rsbuild-plugin-angular/src/lib/plugin/utils/utils.unit.test.ts
|
View your CI Pipeline Execution ↗ for commit af57e13.
☁️ Nx Cloud last updated this comment at |
BioPhoton
commented
Jan 12, 2025
| @@ -22,7 +22,7 @@ | |||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | |||
| * SOFTWARE. | |||
| */ | |||
| import { SourceFileCache } from './source-file-cache'; | |||
| import { SourceFileCache } from '../utils/source-file-cache'; | |||
There was a problem hiding this comment.
I assume this was a left over?
BioPhoton
commented
Jan 12, 2025
packages/rsbuild-plugin-angular/src/lib/plugin/utils/component-resolvers.ts
Show resolved
Hide resolved
Coly010
approved these changes
Jan 13, 2025
BioPhoton
added a commit
to BioPhoton/ng-rspack-build
that referenced
this pull request
Jan 14, 2025
BioPhoton
added a commit
to BioPhoton/ng-rspack-build
that referenced
this pull request
Jan 14, 2025
BioPhoton
added a commit
to BioPhoton/ng-rspack-build
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
rsbuild-plugin-angular