Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2934

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Fixes #2934

merged 6 commits into from
Jan 13, 2025
+37 −10

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Jan 13, 2025 •
edited
Loading

  • Handle correctly RPC call errors from the API
  • Don't clean mempool on catchup
  • Retry 5 times when getting invalid Json with status 200 from Bitcoin Core
  • Add mainnet checkpoint for block 879058 and testnet4 checkpoint for block 64493
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama changed the title Handle correctly RPC call errors from the API Fixes Jan 13, 2025
@ouziel-slama ouziel-slama merged commit 7b00b54 into develop Jan 13, 2025
19 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch January 13, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel