update emulator to new image with correct vendor for Intel and re-enable disabled tests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled tests. the csm-rie:1.5.3 image incorrectly identified the Intel mockup as a "Cray". This is fixed in 1.5.4 by way of Cray-HPE/csm-redfish-interface-emulator#10 and the vendor detection by gru now works with this emulator. Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
rustydb
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Re-enables some tests that failed due to an invalid vendor key in the emulator. The tests now work because the Intel mockup properly identifies itself as "Intel" instead of "Cray"
The csm-rie:1.5.3 image incorrectly identified the Intel mockup as a "Cray". This is fixed in 1.5.4 by way of Cray-HPE/csm-redfish-interface-emulator#10 and the vendor detection by gru now works with this emulator.
Issue Type
Risks and Mitigations
Low.