Skip to content

Commit

Permalink
Update Ruby version to v3.4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
tim-s-ccs committed Jan 9, 2025
1 parent f42a9c9 commit 1640f77
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require:

AllCops:
NewCops: enable
TargetRubyVersion: 3.3
TargetRubyVersion: 3.4
Exclude:
- 'db/**/*'
- 'script/**/*'
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.6
3.4.1
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Upgrade ruby version to v3.4.1 ([PR 982](https://github.com/Crown-Commercial-Service/pmp-idam/pull/982))
- Upgrade alpine version to v3.21 ([PR 982](https://github.com/Crown-Commercial-Service/pmp-idam/pull/982))
- Update ruby to v3.3.6 ([PR 932](https://github.com/Crown-Commercial-Service/pmp-idam/pull/932))
- Update Node to LTS Jod (v22.11.0) ([PR 931](https://github.com/Crown-Commercial-Service/pmp-idam/pull/931))
- Update alpine to v3.20 ([PR 841](https://github.com/Crown-Commercial-Service/pmp-idam/pull/841))
Expand Down
10 changes: 7 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
# Set the alpine version so they match for both images
ARG ALPINE_VERSION=3.20
ARG ALPINE_VERSION=3.21

# Set the NodeJS version
ARG NODE_VERSION=jod

# Set the Ruby version
ARG RUBY_VERSION=3.3.6
ARG RUBY_VERSION=3.4.1

# Pull in the NodeJS image
FROM node:${NODE_VERSION}-alpine${ALPINE_VERSION} AS node

# Remove yarn as we already have it downloaded in the app
RUN rm /usr/local/bin/yarn && \
rm /usr/local/bin/yarnpkg

# Pull in the Ruby image
FROM ruby:${RUBY_VERSION}-alpine${ALPINE_VERSION} AS base

Expand All @@ -32,14 +36,14 @@ FROM base AS build
# to our current ruby build image stage
# so that the ruby image build stage has the correct nodejs version
COPY --from=node /usr/local/bin /usr/local/bin
COPY --from=node /usr/local/lib /usr/local/lib

# Install application dependencies
RUN apk add --update --no-cache \
build-base \
curl \
git \
libpq-dev \
npm \
tzdata

# Enable corepack for yarn
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby '3.3.6'
ruby '3.4.1'

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '~> 7.1.5'
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ DEPENDENCIES
web-console (~> 4.2.1)

RUBY VERSION
ruby 3.3.6p108
ruby 3.4.1p0

BUNDLED WITH
2.4.6
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This README assumes you are using a MacBook. If you are using a different operat


### Ruby
This is a Ruby on Rails application using ruby version `3.3.6`.
This is a Ruby on Rails application using ruby version `3.4.1`.
Ensure that, if you are using a ruby environment manager, the correct ruby version is being run in your development environment.

This project uses Ruby Gems so you will need to install bundler which can be done with:
Expand Down

0 comments on commit 1640f77

Please sign in to comment.