Fix fixer #1133
Merged
Fix fixer #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
approved these changes
Nov 27, 2024
GuillaumeDSM
force-pushed
the
fix_fixer
branch
from
c800d36 to
a67fa77
Compare
GuillaumeDSM
commented
Nov 27, 2024
| and is_ms_valid(limits_amount.get(Ecmsc.LIMITS_AMOUNT_MIN.value)) | ||
| ): | ||
| # min cost can be computed from min price and amount: those values come from exchange data | ||
| cost_min = limits_price.get(Ecmsc.LIMITS_PRICE_MIN.value) * limits_amount.get(Ecmsc.LIMITS_AMOUNT_MIN.value) |
There was a problem hiding this comment.
I updated this part to be sure not to create invalid values
There was a problem hiding this comment.
Could we test that I does not create invalid values please?
There was a problem hiding this comment.
I don't understand as I don't see any new test
GuillaumeDSM
force-pushed
the
fix_fixer
branch
from
a67fa77 to
c8d65e9
Compare
GuillaumeDSM
force-pushed
the
fix_fixer
branch
from
c8d65e9 to
fa25ed5
Compare
Herklos
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.