-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RFC 007 #125
base: main
Are you sure you want to change the base?
Improve RFC 007 #125
Conversation
</td> | ||
</tr> | ||
<tr> | ||
<td colspan="3"><strong><code>id</code></strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced on the need for this. Can you explain some use cases for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of 'id' is for the bank to be able to keep track of when they have issued which PWA covering what funding source to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not convinced why. They can do that already using iat
and sub
and information in the funding source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's about convenience and the possibility for the bank to retrieve the context about this credential from their internal systems with a simple query across one column containing unique values. -- Would you be happier if we make 'id' optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rely on standard claim jti
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be cool with optional jti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I updated accordingly.
<tr> | ||
<td colspan="3"><strong><code>iss</code></strong> | ||
</td> | ||
<td>REQUIRED. Issuer of the credential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to mention somewhere that these (and aud etc) are registered claims when using sd-jwt vc. I do like these being mentioned explicitly as they here though, to explain how we expect them to be used for a PWA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, happy for you to go ahead and make a proposal.
This PR also addresses #118.