Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RFC 007 #125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

stefan-kauhaus
Copy link
Contributor

  • Introduced table with attributes and possible values
  • Updated the JSON example accordingly
  • Smaller edits and update to References section

This PR also addresses #118.

</td>
</tr>
<tr>
<td colspan="3"><strong><code>id</code></strong>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced on the need for this. Can you explain some use cases for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of 'id' is for the bank to be able to keep track of when they have issued which PWA covering what funding source to the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not convinced why. They can do that already using iat and sub and information in the funding source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's about convenience and the possibility for the bank to retrieve the context about this credential from their internal systems with a simple query across one column containing unique values. -- Would you be happier if we make 'id' optional?

Copy link
Collaborator

@georgepadayatti georgepadayatti Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rely on standard claim jti instead ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be cool with optional jti

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I updated accordingly.

<tr>
<td colspan="3"><strong><code>iss</code></strong>
</td>
<td>REQUIRED. Issuer of the credential.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to mention somewhere that these (and aud etc) are registered claims when using sd-jwt vc. I do like these being mentioned explicitly as they here though, to explain how we expect them to be used for a PWA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, happy for you to go ahead and make a proposal.

@stefan-kauhaus stefan-kauhaus marked this pull request as ready for review January 8, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants