Skip to content

Commit

Permalink
Add names to the deprecated functions to not break abi (#34)
Browse files Browse the repository at this point in the history
* Add names to the deprecated functions to not break abi

* remove unwanted changes
  • Loading branch information
Sneh1999 authored Dec 6, 2024
1 parent 998a437 commit 418efec
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
13 changes: 8 additions & 5 deletions src/bridge/SequencerInbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox
Deprecated because we created another `initialize` function that accepts the `EspressoTEEVerifier` contract
address as a parameter which is used by the `SequencerInbox` contract to verify the TEE attestation quote.
*/
function initialize(IBridge, ISequencerInbox.MaxTimeVariation calldata) external onlyDelegated {
function initialize(
IBridge bridge_,
ISequencerInbox.MaxTimeVariation calldata maxTimeVariation_
) external onlyDelegated {
revert Deprecated();
}

Expand Down Expand Up @@ -341,10 +344,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox

/// @dev Deprecated, kept for abi generation and will be removed in the future
function addSequencerL2BatchFromOrigin(
uint256,
bytes calldata,
uint256,
IGasRefunder
uint256 sequencerNumber,
bytes calldata data,
uint256 afterDelayedMessagesRead,
IGasRefunder gasRefunder
) external pure {
revert Deprecated();
}
Expand Down
8 changes: 4 additions & 4 deletions src/rollup/BridgeCreator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ contract BridgeCreator is Ownable {
* been posted by a batch poster running in the TEE.
*/
function createBridge(
address,
address,
address,
ISequencerInbox.MaxTimeVariation calldata
address adminProxy,
address rollup,
address nativeToken,
ISequencerInbox.MaxTimeVariation calldata maxTimeVariation
) external returns (BridgeContracts memory) {
revert Deprecated();
}
Expand Down

0 comments on commit 418efec

Please sign in to comment.