Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated database connection for use with CouchDB #104

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

fernqvist
Copy link
Contributor

Added support for use with Apache CouchDB as a database.

Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some typing issues that needs to be adressed. You can run npm run typecheck to verify locally. Perhaps missing some types for nanodb?

src/db_manager.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now
We are missing the support for limit and offset (server-side pagination) but we can take that in another PR

@birme birme merged commit 8fa0111 into main Dec 4, 2024
4 checks passed
@birme birme deleted the feat/couchdb branch December 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants