Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulsar-1 #39

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Pulsar-1 #39

merged 6 commits into from
Aug 21, 2024

Conversation

pravirkr
Copy link
Collaborator

Significant changes in the pulsar-related modules.

  • Prefer composition over inheritance for data structures. To support different metadata and attributes without complicating the class namespace with various numpy methods. Also, at some point, we need to keep track of more than one numpy array (variance) for proper normalization.
  • This would cause breaking changes in API for a major part of the package.
  • Added more tests. Verified several parts that have been untouched and improved performance.

New additions

  • A module for match filtering and several methods for noise estimation.

@pravirkr pravirkr added the enhancement New feature or request label Aug 21, 2024
@pravirkr pravirkr merged commit 6ac524c into main Aug 21, 2024
8 checks passed
@pravirkr pravirkr deleted the pulsar branch August 21, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pravirkr