Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update api endpoint #45

Merged
merged 1 commit into from
Jul 30, 2024
Merged

update api endpoint #45

merged 1 commit into from
Jul 30, 2024

Conversation

xgui3783
Copy link
Member

should fix #44

@xgui3783
Copy link
Member Author

xgui3783 commented Jul 26, 2024

the failed test is likely due to the the resource that was given to v1 endpoint is signficantly reduced. (1G memory limit).

As a ressult, low resource intensive tasks such as atlas querying would work, getting region specifics (which requires getting the region map etc) would be killed due to OOM.

this is also one of the reason why #43 should be persued. the corresponding v3 API call would be:

curl 'https://siibra-api-stable.apps.hbp.eu/v3_0/regions/Component%2057%3A%20Superior%20parietal%20lobule?parcellation_id=minds%2Fcore%2Fparcellationatlas%2Fv1.0.0%2Fd80fbab2-ce7f-4901-a3a2-3c8ef8a3b721&space_id=minds%2Fcore%2Freferencespace%2Fv1.0.0%2Fdafcffc5-4826-4bf1-8ff6-46b8a31ff8e2'

(n.b. the region name change. see FZJ-INM1-BDA/siibra-configurations@3aa5818)

works without a hitch.

@dickscheid dickscheid merged commit b9fe5f0 into main Jul 30, 2024
1 check failed
@xgui3783 xgui3783 deleted the fix_APIendpoint branch August 1, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live script fails when visualizing template
2 participants