Fix plugin change the result when updating view model

Flow-Launcher · Dec 8, 2024 · 26d97a2 · 26d97a2
1 parent 30938f1
commit 26d97a2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -233,8 +233,11 @@ private void RegisterResultsUpdatedEvent()
 
                     var token = e.Token == default ? _updateToken : e.Token;
 
-                    PluginManager.UpdatePluginMetadata(e.Results, pair.Metadata, e.Query);
-                    if (!_resultsUpdateChannelWriter.TryWrite(new ResultsForUpdate(e.Results, pair.Metadata, e.Query,
+                    // make a copy of results to avoid plugin change the result when updating view model
+                    var resultsCopy = e.Results.ToList();
+
+                    PluginManager.UpdatePluginMetadata(resultsCopy, pair.Metadata, e.Query);
+                    if (!_resultsUpdateChannelWriter.TryWrite(new ResultsForUpdate(resultsCopy, pair.Metadata, e.Query,
                             token)))
                     {
                         Log.Error("MainViewModel", "Unable to add item to Result Update Queue");