-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use memorypack instead of binaryformatter #2418
Conversation
oops I also includes change in #2416 for testing, let me remove it |
f3f70a6
to
8355324
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As in the final exe installer? |
This change touches the core code, make sure you thoroughly test, e.g. fresh install & existing plugins. |
no I mean the cache. like 150k -> 200k. pretty trivial and nobody will care |
Na not much service is using that. Only the ImageCache and Program plugin, and both seem working fine |
@taooceros build failed |
fixed @jjw24 |
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (12)
To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/6993776086/attempts/1' OR To have the bot accept them for you, reply quoting the following line: Errors (3)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
BinaryFormatter has been obsolete for a long time, so let's change it.
https://github.com/Cysharp/MemoryPack seems to be a nice choice. Good thing is that it supports circular reference. Though I think this is no longer a problem because uwpapp no longer reference back to their package.
The payload size seems to be slightly larger, but I think that's not a problem.