Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use memorypack instead of binaryformatter #2418

Merged
merged 3 commits into from
Nov 26, 2023
Merged

use memorypack instead of binaryformatter #2418

merged 3 commits into from
Nov 26, 2023

Conversation

taooceros
Copy link
Member

BinaryFormatter has been obsolete for a long time, so let's change it.

https://github.com/Cysharp/MemoryPack seems to be a nice choice. Good thing is that it supports circular reference. Though I think this is no longer a problem because uwpapp no longer reference back to their package.

The payload size seems to be slightly larger, but I think that's not a problem.

@taooceros
Copy link
Member Author

oops I also includes change in #2416 for testing, let me remove it

This comment has been minimized.

This comment has been minimized.

@jjw24
Copy link
Member

jjw24 commented Nov 12, 2023

The payload size seems to be slightly larger, but I think that's not a problem.

As in the final exe installer?

@jjw24
Copy link
Member

jjw24 commented Nov 12, 2023

This change touches the core code, make sure you thoroughly test, e.g. fresh install & existing plugins.

@taooceros
Copy link
Member Author

The payload size seems to be slightly larger, but I think that's not a problem.

As in the final exe installer?

no I mean the cache. like 150k -> 200k. pretty trivial and nobody will care

@taooceros
Copy link
Member Author

This change touches the core code, make sure you thoroughly test, e.g. fresh install & existing plugins.

Na not much service is using that. Only the ImageCache and Program plugin, and both seem working fine

@jjw24
Copy link
Member

jjw24 commented Nov 19, 2023

@taooceros build failed

@taooceros
Copy link
Member Author

fixed @jjw24

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (12)
binaryformatter
dlgtitle
Linq
Loadertask
memorypack
Pbgra
Reloadable
rescap
sessionending
Stroage
uap
yyy
To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the binary_formatter branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/6993776086/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Errors (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 6
ℹ️ no-newline-at-eof 1
ℹ️ non-alpha-in-dictionary 9

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 added the enhancement New feature or request label Nov 26, 2023
@jjw24 jjw24 added this to the 1.17.0 milestone Nov 26, 2023
@jjw24 jjw24 merged commit 062c6b5 into dev Nov 26, 2023
2 checks passed
@jjw24 jjw24 deleted the binary_formatter branch November 26, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants