fixed [FragLand#216](FragLand#216) for javascript, PHP and Python

[molanp]

fixed FragLand#216 for javascript, PHP and Python

[AppVeyorBot]

✅ Build minestat 1.0.0.414 completed (commit 93a055b9c5 by @)

[AppVeyorBot]

✅ Build minestat 1.0.0.420 completed (commit 6e89565753 by @ldilley)

[AppVeyorBot]

✅ Build minestat 1.0.0.421 completed (commit a41609e707 by @ldilley)

[ldilley]

Greetings, @molanp.

In reference to issue #216, only data returned from SLP 1.7 JSON queries is potentially impacted, correct? If this is the case, then the JavaScript changes in this PR are unnecessary considering that the JavaScript implementation only supports SLP 1.4/1.5. Furthermore, the included PHP modifications would not correct the issue for SLP 1.7. The changes would need to be made to the following lines (613 and 614) in minestat.php:

      $this->current_players = (int)@$json_data['players']['online'];
      $this->max_players = (int)@$json_data['players']['max'];

Tagging @mindsolve to see if he has any input for the proposed Python changes.

[mindsolve]

Thanks for the ping, ldilley :)

I just have one small comment for the python edition.
Thank you, @molanp for the contribution!

[molanp]

Done.

[AppVeyorBot]

✅ Build minestat 1.0.0.432 completed (commit 985a48c475 by @)

[mindsolve]

In regards to the Python parts: Approved, thanks for the addition!

[AppVeyorBot]

✅ Build minestat 1.0.0.433 completed (commit 1aa28a7a78 by @ldilley)

[AppVeyorBot]

✅ Build minestat 1.0.0.434 completed (commit 0459d90c6d by @ldilley)

[AppVeyorBot]

✅ Build minestat 1.0.0.435 completed (commit c7dcf66848 by @ldilley)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[ldilley]

The JavaScript and PHP changes now look good as well. Thank you for the fixes, @molanp!