Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments, indents and pom.xml #246

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Improve comments, indents and pom.xml #246

merged 6 commits into from
Sep 28, 2024

Conversation

TENIOS
Copy link
Contributor

@TENIOS TENIOS commented Sep 27, 2024

I changed the comment blocks for a better look and corrected the date to the current year. In addition, fixed the indentation in the test class.

In the pom.xml file, I moved the dependencies according to their usage, changed the protocol to https and moved the name, description and url tags to a separate section.

My opinion is to move the source code to the src/main/java directory and the test code to src/test/java in order not to reassign them to sourceDirectory and testSourceDirectory. But I don't often work with pom.xml so I can't guarantee the same build. In addition, I would like to change the indentation in the code from 2 to 4 as it usually is and change the position of the curly braces. The best option would be to add .gitignore and .editorconfig files to each project for each language.

@AppVeyorBot
Copy link

Build minestat 1.0.0.477 completed (commit 4762f66535 by @TENIOS)

@TENIOS TENIOS mentioned this pull request Sep 27, 2024
@ldilley ldilley self-requested a review September 28, 2024 00:04
@ldilley ldilley added lang: Java Affects the Java version of minestat enhancement Enhance an existing feature labels Sep 28, 2024
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link

@ldilley
Copy link
Member

ldilley commented Sep 28, 2024

I have fixed the spacing and the placement of open parentheses where applicable. Please refer to https://github.com/FragLand/minestat/blob/master/.github/CONTRIBUTING.md for guidance on styling. This project uses 2 spaces for indentation, no tabs, and the Allman style for blocks.

@ldilley ldilley merged commit 2c4debb into FragLand:master Sep 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance an existing feature lang: Java Affects the Java version of minestat
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants