-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve comments, indents and pom.xml #246
Conversation
✅ Build minestat 1.0.0.477 completed (commit 4762f66535 by @TENIOS) |
✅ Build minestat 1.0.0.478 completed (commit 65bc66b2bf by @ldilley) |
✅ Build minestat 1.0.0.479 completed (commit c9bab4cb84 by @ldilley) |
✅ Build minestat 1.0.0.480 completed (commit 5a5f5b9365 by @ldilley) |
Quality Gate passedIssues Measures |
I have fixed the spacing and the placement of open parentheses where applicable. Please refer to https://github.com/FragLand/minestat/blob/master/.github/CONTRIBUTING.md for guidance on styling. This project uses 2 spaces for indentation, no tabs, and the Allman style for blocks. |
I changed the comment blocks for a better look and corrected the date to the current year. In addition, fixed the indentation in the test class.
In the
pom.xml
file, I moved the dependencies according to their usage, changed the protocol tohttps
and moved thename
,description
andurl
tags to a separate section.My opinion is to move the source code to the
src/main/java
directory and the test code tosrc/test/java
in order not to reassign them tosourceDirectory
andtestSourceDirectory
. But I don't often work withpom.xml
so I can't guarantee the same build. In addition, I would like to change the indentation in the code from 2 to 4 as it usually is and change the position of the curly braces. The best option would be to add.gitignore
and.editorconfig
files to each project for each language.