small fixes

Fran-Rg · May 6, 2024 · 7c34a19 · 7c34a19
1 parent dd9bebf
commit 7c34a19
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/on-cron-lore.yaml b/.github/workflows/on-cron-lore.yaml
@@ -65,13 +65,13 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set up Python
-        if: ${{ steps.champ-count.outputs.CHAMP_COUNT != steps.last-release.outputs.PREVIOUS_CHAMP_COUNT && inputs.dburl == '' }}
+        if: ${{ steps.champ-count.outputs.CHAMP_COUNT != steps.last-release.outputs.PREVIOUS_CHAMP_COUNT || inputs.dburl != '' }}
         uses: actions/setup-python@v4
         with:
           python-version: "3.12"
 
       - name: Requirements
-        if: ${{ steps.champ-count.outputs.CHAMP_COUNT != steps.last-release.outputs.PREVIOUS_CHAMP_COUNT && inputs.dburl == '' }}
+        if: ${{ steps.champ-count.outputs.CHAMP_COUNT != steps.last-release.outputs.PREVIOUS_CHAMP_COUNT || inputs.dburl != '' }}
         run: |
           chmod +x ./install.sh
           ./install.sh

diff --git a/.gitignore b/.gitignore
@@ -76,6 +76,7 @@ instance/
 
 # Scrapy stuff:
 .scrapy
+.scrapy*
 
 # Sphinx documentation
 docs/_build/

diff --git a/leaguelore/spiders/champions.py b/leaguelore/spiders/champions.py
@@ -233,7 +233,8 @@ def parse_champion(self, response, **kwargs):
             logging.error("No bio for '%s': %s", name, response.url)
 
     def parse_bio(self, response, **kwargs):
-        bio = "".join(i.get() for i in response.xpath('//*[@id="CatchElement"]/*'))
+        # bio = "".join(i.get() for i in response.xpath('//*[@id="CatchElement"]/*'))
+        bio = response.css(".root_3nvd.dark_1RHo").get()
 
         image_url = response.css("div.image_3oOd.backgroundImage_5wQJ")[0].attrib[
             "data-am-url"
@@ -265,7 +266,7 @@ def parse_bio(self, response, **kwargs):
             yield champ_parse
 
     def parse_story(self, response, **kwargs):
-        story = "".join(i.get() for i in response.xpath('//*[@id="CatchElement"]/*'))
+        story = response.css(".root_3nvd.dark_1RHo").get()
         champ_parse = {"story": story} | kwargs
         self.save_champ(champ_parse)
         yield champ_parse