Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clustering example error fixed #635

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

luisheb
Copy link
Contributor

@luisheb luisheb commented Oct 19, 2024

References to issues or other PRs

No issue was reported regarding the error in the clustering example.

Describe the proposed changes

In the clustering example, a couple of the explanations of the code did not match the code itself. For instance you could read:

To see the information in a graphic way, the method plot_clusters() can be used.

However, instead of using plot_clusters(), the following class was used:

ClusterPlot(kmeans, fd, cluster_colors=cluster_colors, cluster_labels=cluster_labels).plot()

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (d0bc82f) to head (2f48baa).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #635   +/-   ##
========================================
  Coverage    86.83%   86.83%           
========================================
  Files          157      157           
  Lines        13522    13522           
========================================
  Hits         11742    11742           
  Misses        1780     1780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small correction.

examples/plot_clustering.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Ramos Carreño <carlosramosca@hotmail.com>
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit d39e009 into GAA-UAM:develop Oct 23, 2024
10 of 11 checks passed
@vnmabus
Copy link
Member

vnmabus commented Oct 23, 2024

@all-contributors Please add @luisheb for documentation.

Copy link
Contributor

@vnmabus

I've put up a pull request to add @luisheb! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants