Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-DSA: Add external API functions #213

Merged
merged 11 commits into from
Jan 7, 2025
Merged

ML-DSA: Add external API functions #213

merged 11 commits into from
Jan 7, 2025

Conversation

marsella
Copy link
Contributor

@marsella marsella commented Jan 2, 2025

Closes #198

  • Rearranges the module structure a little to better support the public API functions separately from the internal functions, and to eventually make it easier to add the hashed class of functions (ML-DSA: Define HashML-DSA external functions #199).
  • Adds the external functions with documentation, including docs about the one deviation with bit ordering.
  • Adds some extra KATs

@marsella
mldsa: extract parameter definition interface #198
c6c367d 
This moves the anonymous interface module defining the parameters for
ML-DSA into a named interface module. This will support having two
separate external APIS for ML-DSA.
@marsella
mldsa: rearrange module structure #198
9c796e0 
- Add a top-level `ML_DSA` module to define the external functions
- Update the instantiation to use the new module instead of the
  `Specification` one.
- Exposes the internal functions from the external module in a submodule
@marsella
mldsa: add keygen implementation #198
113bbb0 
Adjusts the module imports a bit so we don't have to label everything
with `Spec::`.
@marsella
mldsa: add sign implementation #198
4419ab7
@marsella
mldsa: add verify implementation #198
a2e4ca3
@marsella
mldsa: add correctness property #198
c28f3bb
@marsella
mldsa: Add KAT for external API, fix bug #198
925375f 
- Adds documentation to bytesToBits vs join spots.
- Adds and docs a KAT

This doesn't work yet.
@marsella
mldsa: add implementation requirements #198
d6d8826
@marsella
mldsa: add hedged KATs #198
5059a05 
- Refactors the tests to support both hedged and deterministic signing
- Adds two hedged KATs for raw and pure APIs
@marsella marsella linked an issue Jan 2, 2025 that may be closed by this pull request
ML-DSA: Define external functions #198
Closed
6 tasks
@marsella marsella changed the base branch from master to 192-verify January 2, 2025 22:15
@marsella marsella mentioned this pull request Jan 3, 2025
Merged
Base automatically changed from 192-verify to master January 3, 2025 15:46
@marsella
mldsa: add copyright info #198
d755d96
@marsella
mldsa: add docs about timing #198
babb9b4 
Updates the hint property to run faster, with a note about prove time.
mccleeary-galois
mccleeary-galois approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mccleeary-galois mccleeary-galois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for changing the :prove to a :check

@marsella marsella merged commit 74784ab into master Jan 7, 2025
2 checks passed
@marsella marsella deleted the 198-external branch January 7, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccleeary-galois mccleeary-galois mccleeary-galois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ML-DSA: Define external functions
2 participants
@marsella @mccleeary-galois