[CS-05] protofile for microservices communication #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshaman
requested changes
Oct 19, 2022
| } | ||
|
|
||
| message IssueCertificateResp { | ||
| string name = 1; |
There was a problem hiding this comment.
oneof {} - мы его не говорили, чтобы не усложнять. Но вот тут можно использовать
api/proto/proto/certificate.proto
Outdated
| } | ||
|
|
||
| message StudentMessage { | ||
| string forename = 1; |
There was a problem hiding this comment.
forename - немного устаревшее слово. Чаще всё же firstname
surname тоже обычно называется lastname
api/proto/proto/certificate.proto
Outdated
|
|
||
| message IssueCertificateReq { | ||
| StudentMessage student = 1; | ||
| string templateName = 2; |
There was a problem hiding this comment.
Составные слова в прото чаще template_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS-05
What:
Protofile
Why:
Set up communication between microservices
How:
By using gRPC