Fix poor choice of using '-' instead of '_'.

README.md

@@ -20,7 +20,7 @@ The API returns a list of competences with the following structure:
 [
     {
         "competence_id": 0,
-        "i18n-key": "the-key"
+        "i18n_key": "the-key"
     },
     ...
 ]

app/models/competence.py

@@ -12,7 +12,7 @@ class Competence(database.Model):  # type: ignore
     __tablename__ = 'competence'
 
     competence_id = database.Column(database.Integer, primary_key=True)
-    i18n_key = database.Column(database.String(255), name='i18n-key')
+    i18n_key = database.Column(database.String(255), name='i18n_key')
 
     def to_dict(self) -> dict:
         """
@@ -22,5 +22,5 @@ def to_dict(self) -> dict:
         """
         return {
             'competence_id': self.competence_id,
-            'i18n-key': self.i18n_key
+            'i18n_key': self.i18n_key
         }

tests/routes/test_competences_route.py

@@ -16,8 +16,8 @@ def test_get_competences_success(app_with_client):
             '/api/application-form/competences/',
             headers={'Authorization': f'Bearer {token}'})
     assert response.status_code == StatusCodes.OK
-    assert response.json == [{'competence_id': 1, 'i18n-key': 'tester'},
-                             {'competence_id': 2, 'i18n-key': 'developer'}]
+    assert response.json == [{'competence_id': 1, 'i18n_key': 'tester'},
+                             {'competence_id': 2, 'i18n_key': 'developer'}]
 
     remove_competences_from_db(app)
 

tests/services/test_competences_service.py

@@ -13,8 +13,8 @@ def test_fetch_competences_success(app_with_client):
     setup_competences_in_db(app)
     with app.app_context():
         result = fetch_competences()
-        assert result == [{'competence_id': 1, 'i18n-key': 'tester'},
-                          {'competence_id': 2, 'i18n-key': 'developer'}]
+        assert result == [{'competence_id': 1, 'i18n_key': 'tester'},
+                          {'competence_id': 2, 'i18n_key': 'developer'}]
 
     remove_competences_from_db(app)