Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add public clients support #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nirav-Gaglani
Copy link

Fixes Issue

Closes #46

Changes proposed

  • Added none option to Token endpoint auth method
  • Conditional rendering of client secret input based on the selected token endpoint auth method

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Client secret required when token endpoint method is other than none
image

Client secret not required when token endpoint method is none
image

Note to reviewers

  • Inorder to create public client, none option has been added to token endpoint auth method dropdown.
  • Client secret has been removed when none is selected, else it is required

@Nirav-Gaglani Nirav-Gaglani requested a review from munir131 June 20, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Creating Public Clients
2 participants