Send connectivity error report to specified collector destination #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
reviewed
Oct 10, 2023
change collector flag to report-to Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
change NewBuffer to NewReader Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
fortuna
requested changes
Oct 16, 2023
| @@ -83,12 +85,44 @@ func unwrapAll(err error) error { | |||
| } | |||
| } | |||
|
|
|||
| func sendReport(record jsonRecord, collectorFlag *string) error { | |||
There was a problem hiding this comment.
This is clearer:
Suggested change
| func sendReport(record jsonRecord, collectorFlag *string) error { | |
| func sendReport(record jsonRecord, collectorURL string) error { |
| func main() { | ||
| verboseFlag := flag.Bool("v", false, "Enable debug output") | ||
| transportFlag := flag.String("transport", "", "Transport config") | ||
| domainFlag := flag.String("domain", "example.com.", "Domain name to resolve in the test") | ||
| resolverFlag := flag.String("resolver", "8.8.8.8,2001:4860:4860::8888", "Comma-separated list of addresses of DNS resolver to use for the test") | ||
| protoFlag := flag.String("proto", "tcp,udp", "Comma-separated list of the protocols to test. Muse be \"tcp\", \"udp\", or a combination of them") | ||
| collectorFlag := flag.String("report-to", "", "URL to send JSON error reports to") |
There was a problem hiding this comment.
Perhaps name the variable to match the flag, for clarity:
Suggested change
| collectorFlag := flag.String("report-to", "", "URL to send JSON error reports to") | |
| reportToFlag := flag.String("report-to", "", "URL to send JSON error reports to") |
| @@ -150,6 +184,13 @@ func main() { | |||
| if err != nil { | |||
| log.Fatalf("Failed to output JSON: %v", err) | |||
| } | |||
| // Send error report to collector if specified | |||
| if !success && *collectorFlag != "" { | |||
There was a problem hiding this comment.
Let's add flags for success and failure sampling rates, like NEL: https://www.w3.org/TR/network-error-logging/#sampling-rates
Perhaps -report-success-rate and -report-failure-rate, so they all start with -report-.
Perhaps set defaults to 0.1 and 1.0?
There was a problem hiding this comment.
addressed on new PR
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- Document optimization flags - Use absolute URLs in the fetch examples - Restore split example
Add in one sentence with a link to the Discussions tab.
- More outline-fetch to fetch. `outline-` is redundant and makes commands longer - Add response headers to verbose output - Fix and improve usage strings
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0. - [Commits](golang/net@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0. - [Commits](golang/net@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Expose host and port on mobileproxy * Update README to use new functions
|
@fortuna I made a new branch/PR that applied all the comments discussed here. I messed up this branch and it was not worth spending time to fix it :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Outline connectivity code to accept a new optional `-collector' flag for a URL to send the error report JSON object with a POST call. I tested this with report collector I setup using Apps Script. More info on collector setup can be found here.