Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoxelSniper: The journey through the Fabric of time. Part three: The ability to snipe a single block (and more) #220

Merged
merged 19 commits into from
Oct 30, 2023
Merged

VoxelSniper: The journey through the Fabric of time. Part three: The ability to snipe a single block (and more) #220

merged 19 commits into from
Oct 30, 2023

Conversation

KevinDaGame
Copy link
Owner

@KevinDaGame KevinDaGame commented Sep 20, 2023 •
edited
Loading

#217

TODO:

  • Place a single block in the world
  • Implement the commands needed for the critial path for the snipe brush
  • /v command
  • Performers work (by accident
  • ball brush (and all shapes should) works

@KevinDaGame KevinDaGame marked this pull request as ready for review October 25, 2023 11:19
@KevinDaGame KevinDaGame requested a review from Lennart99 October 25, 2023 11:27
@KevinDaGame KevinDaGame self-assigned this Oct 25, 2023
@KevinDaGame KevinDaGame added the Fabric Fabric Specific label Oct 25, 2023
@KevinDaGame KevinDaGame changed the title VoxelSniper: The journey through the Fabric of time. Part three: The ability to snipe a single block VoxelSniper: The journey through the Fabric of time. Part three: The ability to snipe a single block (and more) Oct 25, 2023
@KevinDaGame KevinDaGame linked an issue Oct 26, 2023 that may be closed by this pull request
Fabric Port #217
Open
@KevinDaGame KevinDaGame removed a link to an issue Oct 26, 2023
Fabric Port #217
Open
Lennart99
Lennart99 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@Lennart99 Lennart99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few small inconsistencies

.../java/com/github/kevdadev/voxelsniperfabric/voxelsniperfabric/blockstate/FabricBlockState.kt Outdated Show resolved Hide resolved
...in/java/com/github/kevdadev/voxelsniperfabric/voxelsniperfabric/blockdata/FabricBlockData.kt Outdated Show resolved Hide resolved
...c/src/main/java/com/github/kevdadev/voxelsniperfabric/voxelsniperfabric/chunk/FabricChunk.kt Outdated Show resolved Hide resolved
KevinDaGame and others added 4 commits October 30, 2023 09:00
@KevinDaGame @Lennart99
Update VoxelSniperFabric/src/main/java/com/github/kevdadev/voxelsnipe…
8f3b12c 
…rfabric/voxelsniperfabric/blockdata/FabricBlockData.kt

Co-authored-by: Lennart99 <23156309+Lennart99@users.noreply.github.com>
@KevinDaGame @Lennart99
Update VoxelSniperFabric/src/main/java/com/github/kevdadev/voxelsnipe…
5f220b7 
…rfabric/voxelsniperfabric/chunk/FabricChunk.kt

Co-authored-by: Lennart99 <23156309+Lennart99@users.noreply.github.com>
@KevinDaGame
Remove unused companion object
29bb4d2
@KevinDaGame
Run code cleanup
1a9addf
@KevinDaGame KevinDaGame merged commit a379c29 into master Oct 30, 2023
1 check passed
@KevinDaGame KevinDaGame deleted the Feat/fabric-implementation branch October 30, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennart99 Lennart99 Lennart99 approved these changes

Assignees

@KevinDaGame KevinDaGame

Labels
Fabric Fabric Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinDaGame @Lennart99