Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): fix lapis dependency to avoid pgmoon duplication #3

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Jul 12, 2023

Kong is currently using its own fork of pgmoon called kong-pgmoon
https://github.com/Kong/pgmoon/blob/d43ec5366d12dcab6a8e1207e8d4b2c7120c0b62/kong-pgmoon-2.3.2.0-1.rockspec#L1

Pinning the package pgmoon here will result in duplicate pgmoon installed in the Kong package

KAG-1695

@windmgc windmgc requested a review from bungle July 12, 2023 08:40
@Tieske
Copy link
Member

Tieske commented Jul 12, 2023

the rockspecs we actually use are not on this branch (master), there should be another one

@windmgc
Copy link
Member Author

windmgc commented Jul 12, 2023

@Tieske Nice finding! I was just wondering how did those release come from 😃

@Tieske
Copy link
Member

Tieske commented Jul 12, 2023

this one is the latest; https://github.com/Kong/lapis/tree/chore/kong-lapis-1.14.0.2

But that branch doesn't have a rockspec.

@bungle how does this work? should we just download the current rockspec from LuaRocks, update the dependency and the rockspec revision, and then upload again? without comitting it in this repo?

@bungle
Copy link
Member

bungle commented Oct 23, 2023

@windmgc can you instead open this against:
https://github.com/Kong/lapis/releases/tag/v1.14.0.2

@bungle
Copy link
Member

bungle commented Oct 23, 2023

Or create: chore/kong-lapis-1.14.0.3 out from: https://github.com/Kong/lapis/tree/chore/kong-lapis-1.14.0.2

And get this pr on chore/kong-lapis-1.14.0.3

@windmgc windmgc force-pushed the fix-dep-pgmoon-dup branch from 0c0bb95 to 4270934 Compare October 23, 2023 10:07
@windmgc windmgc changed the base branch from master to chore/kong-lapis-1.14.0.3 October 23, 2023 10:07
@windmgc windmgc force-pushed the fix-dep-pgmoon-dup branch from c2201a5 to bb2f2ec Compare October 24, 2023 05:58
@Kong Kong deleted a comment from CLAassistant Oct 24, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@windmgc windmgc force-pushed the fix-dep-pgmoon-dup branch from 5eb83d1 to 4270934 Compare October 24, 2023 07:40
@windmgc
Copy link
Member Author

windmgc commented Oct 24, 2023

I'm quite confused about the way the CI running, so it might be impossible to fix on this old branch(simply adding lua-cjson in the github workflow won't help, it has other problems).

Since there is no manual on the release process on this library, @bungle I suggest we merge this first since it only contains a dependency name fix, and after the merge, I'm going to:

  • tag the latest commit on the branch [chore/kong-lapis-1.14.0.3] with v1.14.0.3
  • release on github
  • luarocks pack kong-lapis-1.14.0.3-1.rockspec locally and luarocks upload to luarocks
  • update ce/ee dependency accordingly

@windmgc windmgc merged commit 8cfbd69 into chore/kong-lapis-1.14.0.3 Oct 25, 2023
0 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants