-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(*): fix lapis dependency to avoid pgmoon duplication #3
Conversation
the rockspecs we actually use are not on this branch ( |
@Tieske Nice finding! I was just wondering how did those release come from 😃 |
this one is the latest; https://github.com/Kong/lapis/tree/chore/kong-lapis-1.14.0.2 But that branch doesn't have a rockspec. @bungle how does this work? should we just download the current rockspec from LuaRocks, update the dependency and the rockspec revision, and then upload again? without comitting it in this repo? |
@windmgc can you instead open this against: |
Or create: And get this pr on |
0c0bb95
to
4270934
Compare
c2201a5
to
bb2f2ec
Compare
5eb83d1
to
4270934
Compare
I'm quite confused about the way the CI running, so it might be impossible to fix on this old branch(simply adding lua-cjson in the github workflow won't help, it has other problems). Since there is no manual on the release process on this library, @bungle I suggest we merge this first since it only contains a dependency name fix, and after the merge, I'm going to:
|
Kong is currently using its own fork of pgmoon called
kong-pgmoon
https://github.com/Kong/pgmoon/blob/d43ec5366d12dcab6a8e1207e8d4b2c7120c0b62/kong-pgmoon-2.3.2.0-1.rockspec#L1
Pinning the package
pgmoon
here will result in duplicatepgmoon
installed in the Kong packageKAG-1695