Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditionally apply robot name field #9

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Tropix126
Copy link
Collaborator

Previously we would just show a field with no content (or "unnamed" if the name was null). In some cases RE will return "" for some reason instead of null, so that's handled now too. It'll now just not add the field if the string is empty or None.

Previous behavior:
image

@SunkenSplash SunkenSplash self-requested a review January 21, 2024 19:21
Copy link
Collaborator

@SunkenSplash SunkenSplash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SunkenSplash SunkenSplash merged commit f2ed79f into main Jan 21, 2024
1 check passed
@SunkenSplash SunkenSplash deleted the feat/conditional-robot-field branch January 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants