-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade faraday from 1.0 to 2.0 #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - you said you still want to do more testing or is this ready to go?
faraday 2.0 uses different middleware. Upgraded to use follow_redirects. faraday 2.0 has been split up to use many http client libraries Using net-http, so this avoids requiring a dozen adapter gems
@Fryguy I'm good with this now |
@kbrock damn - I just merged this but it does have me concerned now. I recently was using a different gem that had faraday locked to 2.x, and it caused mismatches. I checked ManageIQ core, and this will break core if we release it. In our case, manageiq core includes manageiq-api-client [ref]. However, other gems include faraday locked to
A number of other gems are I think the best way forward is to somehow support both 1.x and 2.x in the same way that the google-cloud-env, google-cloud-auth, and signet gems some how do. |
faraday 2.0 uses different middleware.
Upgraded to use follow_redirects.
faraday 2.0 has been split up to use many http client libraries Using net-http, so this avoids requiring a dozen adapter gems
I would like to test this with tasks to ensure it all still works
Faraday 2.0 only supports ruby 3.0 and higher. had to drop testing (and supporting) ruby 2.7