Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adding support for subcollections and related subresources #80

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[WIP] Adding support for subcollections and related subresources #80

wants to merge 19 commits into from

Conversation

abellotti
Copy link
Member

@abellotti abellotti commented Apr 26, 2018 •
edited
Loading

Adding support for subcollections and related subresources

  • Dynamically driven by the "subcollections" exposed via OPTIONS /api/:collection

  • supports queries and actions

    Queries:
miq.vms.find(166).tags.collect(&:name)
miq.vms.find(166).tags.select(:categorization).collect(&:categorization)

Subcollection Actions:
miq.vms.find(166).tags.assign(:name => "/managed/location/ny")
miq.vms.find(166).tags.assign([{:name => "/managed/location/chicago"}, {:name => "/managed/cc/001"}])

Subcollection resource actions:
miq.vms.find(166).tags.find(32).unassign
miq.vms.find(166).tags.where(:name => "/managed/location/*").collect(&:unassign)

Nested searches with sub resource actions:
miq.providers.find_by(:name => "test-vc").vms.where(:name => "testvm-*").last.tags.where(:name => "environment/testing").unassign

    Fixes: Add support for subcollections queries #31
    Fixes: Add support for subcollection actions #32

abellotti added 19 commits April 2, 2018 14:47
@abellotti
Adding support for subcollections and related subresources
a21b621 
- Dynamically driven by the "subcollections" exposed via OPTIONS /api/:collection
- supports queries and actions

  Queries:
  miq.vms.find(166).tags.collect(&:name)
  miq.vms.find(166).tags.select(:categorization).collect(&:categorization)

  Subcollection Actions:
  miq.vms.find(166).tags.assign(:name => "/managed/location/ny")
  miq.vms.find(166).tags.assign([{:name => "/managed/location/chicago"}, {:name => "/managed/cc/001"}])

  Subcollection resource actions:
  miq.vms.find(166).tags.find(32).unassign
  miq.vms.find(166).tags.where(:name => "/managed/location/*").collect(&:unassign)

Fixes: ManageIQ#31
Fixes: ManageIQ#32
@abellotti
Refactorying/Drying up
944b385 
- Moving action specific action methods for resources and subresources to seperate mixin.
- Moving action specific action methods for collections and subcollections to seperate mixin.
- Moving common queryable methods for collections and subcollections to a common QueryableMixin
@abellotti
Adding rspecs - options, collections and resources
58456c7 
- Updated options response fixture to include subcollections
- Added collection rspecs
- Added resource rspecs
@abellotti
Adding rspecs - subcollections
86572d3 
- Add tests for subcollections
@abellotti
Rspecs - Updated test to used action specific responses
1e4c70e 
- Adding resource actions_vms.json
- Adding subcollection actions_vm_tags.json
@abellotti
Adding rspecs - subresources
2ba97ed 
- Adding tests for subresources
@abellotti
Minor Alignment changes, leveraging subclass for collection spec.
52e3387
@abellotti
Updated PR specs to reflect the latest query enhancements made
a720dab 
with PR# ManageIQ#77
@abellotti
Assure that all mixins are properly namespaced
4ee881d
@abellotti
Common methods each and self.subclass for collections and subcollections
f2c4814 
moved to the common collection mixin
@abellotti
Fully qualify the mixins modules as ManageIQ::API::Client::*
640628c
@abellotti
Simplified filters_from_query_relation method.
0e28739
@abellotti
Removed duplicated code from collection.rb. Those methods were
b374164 
parameters_from_query_relation, filters_from_query_relation and order_parameters_from_query_relation
which really live in the mixins/queryable_mixin.rb
@abellotti
Simplifying order_parameters_from_query_relation. no need to dup opti…
d9d6859 
…ons.
@abellotti
Adding support for nested resource/subcollection queries.
a9cfa51
@abellotti
Only checks for subcollection options if defined as a primary collection
b620767
@abellotti
removing subresource.rb and updated files/specs accordingly
64cccc6
@abellotti
Removing resource_action_mixin.rb since it's only used by resource.rb
0dc969d
@abellotti
Made Subcollection a subclass of Collection and removed the
bcce855 
need for the collection_action_mixin.rb
@abellotti abellotti mentioned this pull request Apr 26, 2018
Closed
@Fryguy Fryguy self-assigned this Jul 6, 2020
@chessbyte
Copy link
Member

@abellotti if this is still a viable PR, then please rebase.

@abellotti
Copy link
Member Author

Yes, these are still viable PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for subcollection actions Add support for subcollections queries
3 participants
@abellotti @chessbyte @Fryguy