Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of vm_reconfigure API requests #1624

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 15, 2021

There are some examples of the vm_provision request format and the vm_reconfigure format is similar but not interchangeable.

This adds an example request/response for the vm_reconfigure
request_type for changing CPU, Memory, Adding a disk, Removing a disk,
and Resizing a disk.

Change to side-menu: ManageIQ/manageiq.org#1042

@agrare
Copy link
Member Author

agrare commented Dec 15, 2021

@Fryguy question, do I need to edit https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml in order for this to show up? I don't see these API examples referenced in the _data/site_menu.yml in this repo.

"src_ids":[ "2" ],
"vm_memory": "8192",
"number_of_cpus": 2,
"cores_per_socket": 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE there are other options such as adding/removing disks, nics, cdroms I'll follow-up with those once I validate the format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always driven me nuts, but the menu for the api actually lives in the manageiq.org repo here: https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml

See also ManageIQ/manageiq.org#814

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a reply to #1624 (comment) ?

Yeah okay just confirming, I'll put a PR in to manageiq.org as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah yeah...sorry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare agrare force-pushed the add_reconfigure_vm_example branch from cdb0e9c to 89a3efe Compare December 15, 2021 20:28
@agrare agrare force-pushed the add_reconfigure_vm_example branch 3 times, most recently from 84943c7 to 62a50e5 Compare December 16, 2021 13:57
There are some examples of the vm_provision request format and the
vm_reconfigure format is similar but not interchangeable.

This adds an example request/response for the vm_reconfigure
request_type for changing CPU, Memory, Adding a disk, Removing a disk,
and Resizing a disk.
@agrare agrare force-pushed the add_reconfigure_vm_example branch from 62a50e5 to ed145e8 Compare December 16, 2021 14:00
@agrare agrare changed the title Add an example vm_reconfigure API request Add examples of vm_reconfigure API requests Dec 16, 2021
@miq-bot
Copy link
Member

miq-bot commented Dec 16, 2021

Checked commit agrare@ed145e8 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Dec 16, 2021

Okay I added a few examples of disk reconfig as well: adding, removing, and resizing

@Fryguy Fryguy merged commit ad35e44 into ManageIQ:master Dec 16, 2021
@Fryguy Fryguy self-assigned this Dec 16, 2021
@agrare agrare deleted the add_reconfigure_vm_example branch December 16, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants