-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of vm_reconfigure API requests #1624
Conversation
@Fryguy question, do I need to edit https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml in order for this to show up? I don't see these API examples referenced in the |
"src_ids":[ "2" ], | ||
"vm_memory": "8192", | ||
"number_of_cpus": 2, | ||
"cores_per_socket": 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE there are other options such as adding/removing disks, nics, cdroms I'll follow-up with those once I validate the format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has always driven me nuts, but the menu for the api actually lives in the manageiq.org repo here: https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml
See also ManageIQ/manageiq.org#814
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a reply to #1624 (comment) ?
Yeah okay just confirming, I'll put a PR in to manageiq.org as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah yeah...sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdb0e9c
to
89a3efe
Compare
84943c7
to
62a50e5
Compare
There are some examples of the vm_provision request format and the vm_reconfigure format is similar but not interchangeable. This adds an example request/response for the vm_reconfigure request_type for changing CPU, Memory, Adding a disk, Removing a disk, and Resizing a disk.
62a50e5
to
ed145e8
Compare
Checked commit agrare@ed145e8 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
Okay I added a few examples of disk reconfig as well: adding, removing, and resizing |
There are some examples of the vm_provision request format and the vm_reconfigure format is similar but not interchangeable.
This adds an example request/response for the vm_reconfigure
request_type for changing CPU, Memory, Adding a disk, Removing a disk,
and Resizing a disk.
Change to side-menu: ManageIQ/manageiq.org#1042